Skip zap stack frames in stacktrace output #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, zap only filters out runtime stackframes, which leaves a lot of noise from zap (Error, log, check, etc). This modifies the stacktrace to filter out all zap frames at the beginning of the stack. It will not filter out zap stacks in between non-zap frames. Fixes #488.
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 96.9% 96.93% +0.03%
==========================================
Files 36 36
Lines 2197 2219 +22
==========================================
+ Hits 2129 2151 +22
Misses 59 59
Partials 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, zap only filters out runtime stackframes, which leaves a lot
of noise from zap (Error, log, check, etc). This modifies the stacktrace
to filter out all zap frames at the beginning of the stack. It will not
filter out zap stacks in between non-zap frames.
Fixes #488.